gstreamer1.0-plugins-good: Add patches for pulsedirectsink - #2821
Conversation
Test Results 117 files 698 suites 9h 16m 51s ⏱️ For more details on these failures, see this check. Results for commit 2872169. ♻️ This comment has been updated with latest results. |
| Date: Tue, 28 Jul 2026 14:42:05 +0530 | ||
| Subject: [PATCH] pulse: NULL check before de-reference | ||
|
|
||
| Upstream-Status: Submitted [upstream ticket <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/12144>] |
There was a problem hiding this comment.
It's not a ticket.
| since PulseAudio does not rate-limit an encoded passthrough stream via | ||
| writable-size flow control. | ||
|
|
||
| Upstream-Status: Submitted [upstream ticket <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/12144>] |
There was a problem hiding this comment.
Neither is this
Add a new PulseAudio sink built directly on GstBaseSink rather than GstAudioBaseSink, using the PulseAudio extended-stream API (pa_stream_new_extended / pa_format_info). Unlike pulsesink, which is oriented around a PCM ringbuffer, pulsedirectsink writes encoded frames straight to the server, making it suitable for DSP offload where the sink, not the CPU, performs playout. These patches have been submitted for upstream review. - pulse: NULL check before de-reference - pulse: add pulsedirectsink element Signed-off-by: Bala Sai Kosuri <bkosuri@qti.qualcomm.com>
| sink, not the CPU, performs playout. | ||
|
|
||
| - The element accepts MP3 (MPEG-1 Audio Layer III) only, mapping it to | ||
| PA_ENCODING_MPEG_IEC61937. |
There was a problem hiding this comment.
I've provided several review comments in the GStreamer MR. However, the main question is, how can this be tested? Which platform did you use for testing? I don't see MP3 modules for any of the platforms.
There was a problem hiding this comment.
This has been tested on RB3 Gen2 with an image shared by Audio team with all required changes from their end.
There was a problem hiding this comment.
How to reproduce it with the pristine QLI?
There was a problem hiding this comment.
This is the list of modules / libs that are available for RB3 Gen2:
CFCM.so.1
fastrpc_shell_0
libsns_device_mode_skel.so
libsns_direct_channel_skel.so
libsns_dynamic_loader_skel.so
libsns_remote_proc_state_skel.so
libstabilitydomain_skel.so
libsysmondomain_skel.so
libsysmonquery_skel.so
libsysmon_skel.so
SAPlusCmnModule.so.1
sbc_dec_module.so.1
sbc_enc_module.so.1
smecns_v2_module_fvxiii.so.1
I definitely don't see MP3 here (nor AAC FWIW).
5 participants
Add a new PulseAudio sink built directly on GstBaseSink rather than GstAudioBaseSink, using the PulseAudio extended-stream API (pa_stream_new_extended / pa_format_info). Unlike pulsesink, which is oriented around a PCM ringbuffer, pulsedirectsink writes encoded frames straight to the server, making it suitable for DSP offload where the sink, not the CPU, performs playout.
These patches have been submitted for upstream review.